Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error running pipeline with Nextflow 0.32.0 #95

Closed
edxxgardo opened this issue Sep 28, 2018 · 8 comments
Closed

Error running pipeline with Nextflow 0.32.0 #95

edxxgardo opened this issue Sep 28, 2018 · 8 comments
Labels
bug Something isn't working

Comments

@edxxgardo
Copy link

Yesterday we ran the pipeline with the brand new version of Nextflow. In the attachment the error. We opened another issue when running the same pipeline: #93.

command_error_log.txt
nextflow.log.1.txt

@ewels
Copy link
Member

ewels commented Sep 28, 2018

ERROR ~ Error executing process > 'star (UHR_Rep2_ERCC-Mix1_1)'

Caused by:
  Not a valid memory value: null

Source block:
  prefix = reads[0].toString() - ~/(_R1)?(_trimmed)?(_val_1)?(\.fq)?(\.fastq)?(\.gz)?$/
  def avail_mem = task.memory == null ? '' : "--limitBAMsortRAM ${task.memory.toBytes() - 100000000}"
  seqCenter = params.seqCenter ? "--outSAMattrRGline ID:$prefix 'CN:$params.seqCenter'" : ''
  """
  STAR --genomeDir $index \\
      --sjdbGTFfile $gtf \\
      --readFilesIn $reads  \\
      --runThreadN ${task.cpus} \\
      --twopassMode Basic \\
      --outWigType bedGraph \\
      --outSAMtype BAM SortedByCoordinate $avail_mem \\
      --readFilesCommand zcat \\
      --runDirPerm All_RWX \\
      --outFileNamePrefix $prefix $seqCenter \\
  """

@pditommaso, I guess this is being caused by the statement task.memory == null. Is this something that's changed in the last release? Should this code be replaced with something different?

@ewels ewels added the bug Something isn't working label Sep 28, 2018
@pditommaso
Copy link
Contributor

This seems an issue on NF side, a possible and nicer workaround should be 👍

task.memory ? "--limitBAMsortRAM ${task.memory.toBytes() - 100000000 : ''

@ewels
Copy link
Member

ewels commented Sep 28, 2018

Updated and in PR #96 - tests now running. Thanks both!

@ewels
Copy link
Member

ewels commented Sep 28, 2018

Do you think that this will now be a problem?

withName: '*' { memory = null }

@ewels
Copy link
Member

ewels commented Sep 28, 2018

Hi @edxxgardo,

I've just merged what I hope is a fix into the dev branch. If you could try running again and see if you still get the same problem, that would be great!

Thanks,

Phil

@edxxgardo
Copy link
Author

Thanks. I'll try and get back to you soon.

@edxxgardo
Copy link
Author

Ok, no more memory error. But, the problem with the never ending process mentioned in #93 is still there.

@ewels
Copy link
Member

ewels commented Sep 28, 2018

Great stuff, thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants