Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Bump tower cli version to v0.5 #11

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Bump tower cli version to v0.5 #11

merged 2 commits into from
Mar 2, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Feb 3, 2022

No description provided.

@ewels ewels requested a review from drpatelh February 3, 2022 14:33
@ewels ewels marked this pull request as draft February 3, 2022 14:42
@ewels ewels added the WIP Work in progress label Feb 3, 2022
@ewels
Copy link
Member Author

ewels commented Feb 3, 2022

DO NOT MERGE. This will break everything because of this line in the v0.5 changelog:

At tw launch only accepts full URL repositories as Nextflow pipelines.

We provide ${{ github.repository }}, which is the GitHub repo name, eg. nf-core/viralrecon

ewels added a commit to ewels/nf-core-tools that referenced this pull request Feb 3, 2022
Also removed `pipeline` and `revision` from the AWS workflows, which were not needed.

See nf-core/tower-action#11 for context
action.yml Show resolved Hide resolved
@ewels
Copy link
Member Author

ewels commented Feb 3, 2022

After some discussion in Slack, I don't think that we can automate this away. We'll need to update the nf-core template.

This should be fine as we can set this to be a major version change, leaving existing pipeline code functional with the v0.4 release of the Tower CLI. That will continue to work until v0.4 stops working with https://tower.nf - meanwhile the template update to v3 of this release will use v0.5 of the tw cli and not specify the default, meaning that the default value in this action with the URL prefix will be used.

Could do with some actual testing..

@ewels ewels marked this pull request as ready for review February 3, 2022 15:43
@ewels ewels removed the WIP Work in progress label Feb 3, 2022
@ewels ewels merged commit 03488ed into nf-core:main Mar 2, 2022
@ewels ewels deleted the bump-v0.5 branch March 2, 2022 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants