Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-core/tools v3.0.0 preparation: update docs for new command nf-core pipelines create #2742

Merged
merged 41 commits into from
Oct 8, 2024

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Sep 26, 2024

update docs for new command nf-core pipelines create

Close nf-core/tools#2341

@netlify /blog/2024/tools-3_0_0

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for nf-core-main-site ready!

Name Link
🔨 Latest commit 29738a0
🔍 Latest deploy log https://app.netlify.com/sites/nf-core-main-site/deploys/67051338b0646f000892fc96
😎 Deploy Preview https://deploy-preview-2742--nf-core-main-site.netlify.app/blog/2024/tools-3_0_0
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mirpedrol
Copy link
Member Author

@nf-core-bot fix linting

@mirpedrol
Copy link
Member Author

@nf-core-bot fix linting again please!

@mashehu
Copy link
Contributor

mashehu commented Oct 3, 2024

Also fixes nf-core/tools#3181

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for nf-core-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 29738a0
🔍 Latest deploy log https://app.netlify.com/sites/nf-core-docs/deploys/670513387046880008a50325

mashehu and others added 3 commits October 4, 2024 12:04
@mashehu
Copy link
Contributor

mashehu commented Oct 4, 2024

docs deploy preview is failing because of the added Feature component. it builds locally fine, so no worries.

sites/main-site/src/content/blog/2024/tools-3_0_0.md Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/tools-3_0_0.md Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/tools-3_0_0.md Outdated Show resolved Hide resolved

## ✨ New features

- Enhanced pipeline template customisation: The template has been divided into features that can be selectively included or excluded.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break up these bullets a bit. Description on sub-bullets.

Suggested change
- Enhanced pipeline template customisation: The template has been divided into features that can be selectively included or excluded.
- Enhanced pipeline template customisation
- The template has been divided into features that can be selectively included or excluded.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mashehu think this one got missed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I like a bullet list with just on bullet (for the sub-lists)...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it anyway

sites/main-site/src/content/blog/2024/tools-3_0_0.md Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/tools-3_0_0.md Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/tools-3_0_0.md Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/tools-3_0_0.md Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/tools-3_0_0.md Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/tools-3_0_0.md Outdated Show resolved Hide resolved
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments + sub-bullet point comment thing, then LGTM! 👍🏻

sites/main-site/src/content/blog/2024/tools-3_0_0.md Outdated Show resolved Hide resolved
sites/main-site/src/content/blog/2024/tools-3_0_0.md Outdated Show resolved Hide resolved
@mashehu mashehu merged commit 1fa03ae into nf-core:main Oct 8, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[create] Improve logic in CLI wizard
4 participants