Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional models #69

Merged
merged 63 commits into from
Oct 3, 2024
Merged

Additional models #69

merged 63 commits into from
Oct 3, 2024

Conversation

cconrad8
Copy link
Contributor

  • added antibody, cell line, animal model, and genetic reagant + ui schemas

@cconrad8
Copy link
Contributor Author

Tested some in here: https://sage-bionetworks.github.io/synapse-web-monorepo/?path=/story/ui-dynamicform--nf-data-submission-form

improvements can be made now or at a later time on labels such as
image

Copy link
Contributor

@anngvu anngvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted some suggested fixes.

NF-Tools-Schemas/antibody/submitAntibody.json Outdated Show resolved Hide resolved
NF-Tools-Schemas/antibody/submitAntibody.json Outdated Show resolved Hide resolved
NF-Tools-Schemas/antibody/submitAntibody.json Outdated Show resolved Hide resolved
NF-Tools-Schemas/antibody/submitAntibody.json Outdated Show resolved Hide resolved
NF-Tools-Schemas/antibody/submitAntibody.json Outdated Show resolved Hide resolved
NF-Tools-Schemas/antibody/submitAntibody.json Outdated Show resolved Hide resolved
NF-Tools-Schemas/antibody/submitAntibody.json Outdated Show resolved Hide resolved
NF-Tools-Schemas/genetic-reagant/submitGeneticReagant.json Outdated Show resolved Hide resolved
NF-Tools-Schemas/genetic-reagant/submitGeneticReagant.json Outdated Show resolved Hide resolved
NF-Tools-Schemas/genetic-reagant/submitGeneticReagant.json Outdated Show resolved Hide resolved
@anngvu anngvu requested a review from allaway September 16, 2024 15:39
@cconrad8
Copy link
Contributor Author

cconrad8 commented Sep 30, 2024

scrnli_9_30_2024_7-30-16.PM.mp4

Update: Converted questions to statements, removed antibody and cell line. (want to get a good working product first).

Added if/then conditionality to vendor/investigator and developer. (Shown in video)

Copy link
Contributor

@anngvu anngvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional rendering looks great, and the questions and options make sense except for one section where I spent more time and thought was a little confusing (Bacterial Resistance).

NF-Tools-Schemas/genetic-reagent/submitGeneticReagent.json Outdated Show resolved Hide resolved
@cconrad8 cconrad8 requested a review from anngvu October 1, 2024 20:16
@anngvu anngvu requested a review from allaway October 2, 2024 20:23
@anngvu
Copy link
Contributor

anngvu commented Oct 2, 2024

Note: Some of the question re-wording no longer applied as Efren asked to not use the question format, I think. But some fields were removed to streamline collection.

Copy link
Contributor

@allaway allaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed in person hiding the "id" columns, e.g. geneticReagentId, because these are generated by us. Otherwise, LGTM! Thanks!

@cconrad8 cconrad8 merged commit c6d0df8 into main Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants