-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional models #69
Conversation
cconrad8
commented
Sep 13, 2024
- added antibody, cell line, animal model, and genetic reagant + ui schemas
…mas/obervations/SubmitObservationSchema.json
…hemas/observations/SubmitObservationUiSchema.json
Tested some in here: https://sage-bionetworks.github.io/synapse-web-monorepo/?path=/story/ui-dynamicform--nf-data-submission-form improvements can be made now or at a later time on labels such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted some suggested fixes.
scrnli_9_30_2024_7-30-16.PM.mp4Update: Converted questions to statements, removed antibody and cell line. (want to get a good working product first). Added if/then conditionality to vendor/investigator and developer. (Shown in video) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditional rendering looks great, and the questions and options make sense except for one section where I spent more time and thought was a little confusing (Bacterial Resistance).
Note: Some of the question re-wording no longer applied as Efren asked to not use the question format, I think. But some fields were removed to streamline collection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed in person hiding the "id" columns, e.g. geneticReagentId, because these are generated by us. Otherwise, LGTM! Thanks!