Resolved pedantic warnings; fixed Retina images #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled pedantic warnings, which are enabled in mapbox/mapbox-gl-native, as well as a warning that Xcode recommends. Resolved various warnings, adding an exception around some `MIN()` / `MAX()` usage. Followed up f3393f0 with some renamed methods that match what `+embeddedImageNamed:` now expects.
| @@ -122,7 +122,7 @@ - (UIView *)subtitleViewOrDefault { | |||
|
|
|||
| - (SMCalloutBackgroundView *)backgroundView { | |||
| // create our default background on first access only if it's nil, since you might have set your own background anyway. | |||
| return _backgroundView ?: (_backgroundView = [self defaultBackgroundView]); | |||
There was a problem hiding this comment.
Interesting; the ?: operator causes a warning?
There was a problem hiding this comment.
Yep just reproduced it. That sucks, I love that operator! Oh well.
|
Thanks for the patch! Merging now. |
nfarina
added a commit
that referenced
this pull request
Mar 26, 2015
Resolved pedantic warnings; fixed Retina images
1ec5
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Mar 26, 2015
Resolves several warnings via nfarina/calloutview#78 and nfarina/calloutview#79.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIN()/MAX()usage.+embeddedImageNamed:now expects.