Fix for Open/Close Door Status Bug #12
Conversation
For my specific setup (Chamberlain opener with separate MyQ hub), the Open/Close status of the door would always return closed. I narrowed it down to a "break" command that was exiting the loop through the attributes that in my data set had not yet reach the "doorstate" attribute. This was forcing my door to always assume the default status of 2 which is closed. By removing the break, the code now correctly returns my status. I assume the break was entered for efficiency, but it was simply occurring too soon for my setup.
| @@ -115,7 +115,6 @@ LiftMasterAccessory.prototype = { | |||
| var thisAttributeSet = device.Attributes[j]; | |||
| if (thisAttributeSet.AttributeDisplayName == "desc") { | |||
| thisDoorName = thisAttributeSet.Value; | |||
| break; | |||
There was a problem hiding this comment.
This break seems to assume that the "doorstate" attribute will have already been iterated through. In my case "doorstate" is later in the list and therefore breaking at this point means "doorstate" never gets set. Hence the removal of the break.
|
Would like to see this fix merged in... |
|
This happens to me as well |
|
I can confirm this fixes the open/closed status issue. I suspect homebridge traffic will increase now that iOS 10 with the Home app is out and it'd be nice to have an official release with this fix. Also, this fixes #11. |
|
Hmm. I don't have this issue. I have chamberlain garage door with the separate MYQ hub. Would you being willing to give my fork a try? The code got reworked but has only worked to varying degrees for certain people. |
|
Published! |
For my specific setup (Chamberlain opener with separate MyQ hub), the Open/Close status of the door would always return closed. I narrowed it down to a "break" command that was exiting the loop through the attributes that in my data set had not yet reached the "doorstate" attribute. This was forcing my door to always assume the default status of 2 which is closed. By removing the break, the code now correctly returns my status.
Maybe on other configurations door status always comes before "desc", but not for me.
I assume the break was entered for efficiency, but it was simply occurring too soon for my setup.