Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduced term composition for khatamirad #78

Conversation

HendrikBorgelt
Copy link
Member

Introduced the term composition into the vocabulary for khatamirad. Provenance is currently not correct as the term and namespace for khatamirad does not exist yet.

HendrikBorgelt and others added 2 commits June 3, 2024 12:34
Introduced the term composition into the vocabulary for khatamirad. Provenance is currently not correct as the term and namespace for khatamirad does not exist yet.
@dalito
Copy link
Member

dalito commented Jun 7, 2024

@HendrikBorgelt to fully attribute this to @khatamirad (fully = also in the git-history), he has to submit a PR from his account and we can close this one un-merged. Else we could merged this PR and mention him as co-author.

@khatamirad
Copy link

@HendrikBorgelt to fully attribute this to @khatamirad (fully = also in the git-history), he has to submit a PR from his account and we can close this one un-merged. Else we could merged this PR and mention him as co-author.

@HendrikBorgelt is a pull requet still required? I'm fine by mention as co-author

@dalito
Copy link
Member

dalito commented Jun 10, 2024

The current draft of the definition Concentration of main constituent elements of a material, expressed in weight percentage or mole fraction is too special for a very general term. Why only "main" constituents? Based on what criteria is a constituent element considered "main"? What is meant by element? Can composition be specified by concentration only?

Maybe you could try to define more precisely what you mean by "composition" and/or the context of use.

@HendrikBorgelt
Copy link
Member Author

@khatamirad and @dalito, as i am currently involved in a comference and a lot of work projects I will just be a silent listeren and correct or dismiss the pull request based on your requests. @khatamirad if you want to test the pipeline fully, you can also make an apointment with me and we can finaliyse the submition after the discussion for the term is completed.

@khatamirad
Copy link

@khatamirad and @dalito, as i am currently involved in a comference and a lot of work projects I will just be a silent listeren and correct or dismiss the pull request based on your requests. @khatamirad if you want to test the pipeline fully, you can also make an apointment with me and we can finaliyse the submition after the discussion for the term is completed.

since a master student is going to spend more time on this, I will wait for more input and then submit a PR all at once. I guess this is more straight forward

@HendrikBorgelt
Copy link
Member Author

then I will close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants