-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional tags throw error #255
Comments
Hm. We do test this specific scenario in our unit tests. Could you post a more reproducible example without the dependency on track.getIn? |
Sure, of course, sorry! it resolves to
silly test case, but it seems to still receive some form of child, and therefore breaks :/
|
doctyper
pushed a commit
that referenced
this issue
Mar 24, 2017
doctyper
added a commit
that referenced
this issue
Mar 24, 2017
@irisSchaffer Fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version: 5.0.0
React Version: 15.4.2
I'm experiencing problems with rendering optional tags as so:
Gives me a
TypeError: Cannot read property 'props' of null
. I believe it is this line that is throwing the error: https://github.com/nfl/react-helmet/blob/master/src/Helmet.js#L201If I, however, go with something like
everything works fine and I get the correct description (which was set in the parent).
The text was updated successfully, but these errors were encountered: