Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace requestIdleCallback with requestAnimationFrame for a more consistent DOM write cycle. #307

Merged
merged 3 commits into from
Aug 29, 2017

Conversation

doctyper
Copy link
Contributor

@doctyper doctyper commented Aug 2, 2017

As of Chrome 60, requestIdleCallback is noticeably slower than previous implementations. Not sure if this is by design, but either way Helmet needs a faster DOM write cycle to avoid FOUC.

@doctyper doctyper force-pushed the fix/request-animation-frame branch from abc8b33 to 7ba7bde Compare August 2, 2017 23:16
@codecov
Copy link

codecov bot commented Aug 2, 2017

Codecov Report

Merging #307 into master will decrease coverage by 1.37%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   98.96%   97.59%   -1.38%     
==========================================
  Files           3        3              
  Lines         291      291              
==========================================
- Hits          288      284       -4     
- Misses          3        7       +4
Impacted Files Coverage Δ
src/HelmetUtils.js 96.86% <57.14%> (-1.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3d3bf...7ba7bde. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants