Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drive fix #195

Merged
merged 1 commit into from
Feb 20, 2021
Merged

drive fix #195

merged 1 commit into from
Feb 20, 2021

Conversation

guga31bb
Copy link
Member

No description provided.

@guga31bb
Copy link
Member Author

I think this is safe to do now because we started using order_sequence to put plays in the right order instead of drive, and it fixes #194

@guga31bb
Copy link
Member Author

Checked a few games and it seems identical (except for what it's supposed to fix) so I think this is ok to merge in

@mrcaseb mrcaseb merged commit 320370a into master Feb 20, 2021
@mrcaseb mrcaseb deleted the drive_fixes branch February 20, 2021 19:43
@mrcaseb
Copy link
Member

mrcaseb commented Feb 20, 2021

Hm did you mean to close #183 with this PR instead of #194?

@guga31bb
Copy link
Member Author

Oops so many win probability issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overtime WP not matching rbsdm.com
2 participants