Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOS xyac fix #330

Merged
merged 1 commit into from
May 31, 2022
Merged

JOS xyac fix #330

merged 1 commit into from
May 31, 2022

Conversation

guga31bb
Copy link
Member

No description provided.

@guga31bb guga31bb linked an issue May 31, 2022 that may be closed by this pull request
More xyac issues: James O'Shaughnessy #329
Closed
@guga31bb guga31bb requested a review from mrcaseb May 31, 2022 13:55
@guga31bb
Copy link
Member Author

Updates to the player finder parser weren't being propagated to the xyac stuff resulting in some plays being incorrectly dropped. This should be fixed

mrcaseb
mrcaseb approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@mrcaseb mrcaseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it was something with the parser, thanks!

@mrcaseb mrcaseb enabled auto-merge May 31, 2022 13:57
@mrcaseb mrcaseb merged commit d0a0009 into master May 31, 2022
@mrcaseb mrcaseb deleted the xyac_names branch May 31, 2022 13:59
@github-actions
Copy link

🚀 Deployed on https://6296212133f81163e8abdbab--thirsty-brown-d38ddf.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcaseb mrcaseb mrcaseb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More xyac issues: James O'Shaughnessy
2 participants
@guga31bb @mrcaseb