Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new function for series conversions and series results #393

Merged
merged 8 commits into from
Oct 26, 2022
Merged

Add new function for series conversions and series results #393

merged 8 commits into from
Oct 26, 2022

Conversation

mrcaseb
Copy link
Member

@mrcaseb mrcaseb commented Oct 26, 2022

Output columns need to be documented before converting the draft pr

@github-actions
Copy link

github-actions bot commented Oct 26, 2022 •
edited
Loading

🚀 Deployed on https://63594ada2a2e3908f0cb1d24--thirsty-brown-d38ddf.netlify.app

@mrcaseb mrcaseb marked this pull request as ready for review October 26, 2022 14:16
tanho63
tanho63 approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@tanho63 tanho63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We probably should think about adding some tests at some point rather than skipping everything on CRAN, but that's a future discussion

@mrcaseb mrcaseb merged commit 69f7b0a into master Oct 26, 2022
@mrcaseb mrcaseb deleted the calc-scr branch October 26, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanho63 tanho63 tanho63 approved these changes

@guga31bb guga31bb Awaiting requested review from guga31bb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrcaseb @tanho63 @guga31bb