set kick distance through stat ids #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2023
Closed
Closed
mrcaseb
changed the title
guga31bb
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #421 I attempted to fill NA kick_distance on kickoffs or punts through distance to goal line. However, it turned out that NFL's definition of kick distance (esp. if the kick reaches the endzone) depends on wheter or not the ball is returned.
It also turned out that we actually have the correct kick distance in stat IDs 32, 43, and 44. It was just an inherited mistake from nflscrapR not to write kick distance in these cases.
This PR fixes that probelm so we now should have accurate kick distance on all kickoffs and punts