Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that services aren't reporting being ready too early #1907

Closed
jefflill opened this issue Apr 22, 2024 · 2 comments
Closed

Verify that services aren't reporting being ready too early #1907

jefflill opened this issue Apr 22, 2024 · 2 comments
Assignees
Labels
investigate Needs further investigation

Comments

@jefflill
Copy link
Collaborator

@marcusbooyah reported that he as an InStep service reporting being ready too early. We should verify that we're not making the same mistake for NEIONFORGE related services.

image

@jefflill jefflill self-assigned this Apr 22, 2024
@jefflill jefflill added the investigate Needs further investigation label Apr 22, 2024
@jefflill
Copy link
Collaborator Author

jefflill commented Apr 30, 2024

I'm seeing NEONFORGE services calling this at the beginning of the their OnRunAsync() methods:

await SetStatusAsync(NeonServiceStatus.Starting);
  • This shouldn't be necessary. NeonService is initializing the status file to starting before calling OnRunAsync(). NeonService should also call SetStatusAsync(NeonServiceStatus.Starting) before calling OnRunAsync() and we should remove the service calls to this to simplify things.

  • Let's add a NeonService.Status property as well so services can be aware of their status.

    JEFF: We are already doing this

@jefflill
Copy link
Collaborator Author

jefflill commented May 4, 2024

DONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate Needs further investigation
Projects
None yet
Development

No branches or pull requests

1 participant