-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up output #7
Labels
Comments
wallw-teal
added a commit
to wallw-teal/opensphere-build-resolver
that referenced
this issue
Nov 16, 2019
Plugins can now specify an updater function, which is run when the package has already been resolved once. The resolver/updater functions now take a forth argument which is the ancestry stack (by package name). The config and gcc options plugins use those two new features to update the results. Configs can be promoted to groups in the order CONFIG > PLUGIN > BASE and use the highest depth within their group. The sort value is then (explicitPriority || group - depth). Also used the new ancestry stack to clean up the console output. resolves ngageoint#7
wallw-teal
added a commit
to wallw-teal/opensphere-build-resolver
that referenced
this issue
Nov 22, 2019
Plugins can now specify an updater function, which is run when the package has already been resolved once. The resolver/updater functions now take a forth argument which is the ancestry stack (by package name). Most of the plugins now use those two new features to update the results. Configs can be promoted to groups in the order CONFIG > PLUGIN > BASE and use the highest depth within their group. The sort value is then (explicitPriority || group - depth). Also used the new ancestry stack to clean up the console output. resolves ngageoint#7, ngageoint#18
wallw-teal
added a commit
to wallw-teal/opensphere-build-resolver
that referenced
this issue
Nov 22, 2019
Plugins can now specify an updater function, which is run when the package has already been resolved once. The resolver/updater functions now take a forth argument which is the ancestry stack (by package name). Most of the plugins now use those two new features to update the results. Configs can be promoted to groups in the order CONFIG > PLUGIN > BASE and use the highest depth within their group. The sort value is then (explicitPriority || group - depth). Also used the new ancestry stack to clean up the console output. resolves ngageoint#7, ngageoint#18
🎉 This issue has been resolved in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The resolver tree was changed to process breadth-first rather than depth-first. That change kinda screws up the output, which had a better appearance under the depth-first approach.
The depth-first approach is wrong under the hood, so don't do that. But do clean up the output so that it looks nicer or is easier to trace.
The text was updated successfully, but these errors were encountered: