Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up output #7

Closed
wallw-teal opened this issue Jan 26, 2018 · 1 comment · Fixed by #53
Closed

Clean up output #7

wallw-teal opened this issue Jan 26, 2018 · 1 comment · Fixed by #53
Labels

Comments

@wallw-teal
Copy link
Contributor

The resolver tree was changed to process breadth-first rather than depth-first. That change kinda screws up the output, which had a better appearance under the depth-first approach.

The depth-first approach is wrong under the hood, so don't do that. But do clean up the output so that it looks nicer or is easier to trace.

@wallw-teal wallw-teal changed the title Cleanup output Clean up output Jan 26, 2018
@wallw-teal wallw-teal assigned wallw-teal and unassigned wallw-teal Jan 26, 2018
wallw-teal added a commit to wallw-teal/opensphere-build-resolver that referenced this issue Nov 16, 2019
Plugins can now specify an updater function, which is run when the
package has already been resolved once.

The resolver/updater functions now take a forth argument which is
the ancestry stack (by package name).

The config and gcc options plugins use those two new features to
update the results. Configs can be promoted to groups in the order
CONFIG > PLUGIN > BASE and use the highest depth within their
group. The sort value is then (explicitPriority || group - depth).

Also used the new ancestry stack to clean up the console output.

resolves ngageoint#7
wallw-teal added a commit to wallw-teal/opensphere-build-resolver that referenced this issue Nov 22, 2019
Plugins can now specify an updater function, which is run when the
package has already been resolved once.

The resolver/updater functions now take a forth argument which is
the ancestry stack (by package name).

Most of the plugins now use those two new features to update the
results. Configs can be promoted to groups in the order
CONFIG > PLUGIN > BASE and use the highest depth within their
group. The sort value is then (explicitPriority || group - depth).

Also used the new ancestry stack to clean up the console output.

resolves ngageoint#7, ngageoint#18
wallw-teal added a commit to wallw-teal/opensphere-build-resolver that referenced this issue Nov 22, 2019
Plugins can now specify an updater function, which is run when the
package has already been resolved once.

The resolver/updater functions now take a forth argument which is
the ancestry stack (by package name).

Most of the plugins now use those two new features to update the
results. Configs can be promoted to groups in the order
CONFIG > PLUGIN > BASE and use the highest depth within their
group. The sort value is then (explicitPriority || group - depth).

Also used the new ancestry stack to clean up the console output.

resolves ngageoint#7, ngageoint#18
wallw-teal pushed a commit that referenced this issue Nov 25, 2019
# [6.2.0](v6.1.3...v6.2.0) (2019-11-25)

### Features

* better priority ordering for plugins ([69a3415](69a3415)), closes [#7](#7) [#18](#18)
@wallw-teal
Copy link
Contributor Author

🎉 This issue has been resolved in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant