-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self-signed certs updates as old certs were expired #6524
base: main
Are you sure you want to change the base?
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
Hi @sdutta9, We appreciate your work on this but we are going to do a different approach. We will give you credit for your contribution on our release notes once that becomes available in v4.0.0. I hope you are happy about this. |
Hi @AlexFenlon I care the least about credits as long as the expired certificates are fixed. To me updating certificates is a simple task, and being part of F5 which is a security-first company, I don't feel comfortable sharing an example with expired certificates (even if they are self-signed and only used as a sample example) with customers. I will surely be happy the sooner you fix all expired certs in the main branch. 🙂 |
Proposed changes
As part of this PR, I am updating the old self-signed certs with new ones that are valid for 5 years.
Related Bug: #6433
Checklist
Before creating a PR, run through this checklist and mark each as complete.