Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace glog in flags.go #6530

Merged
merged 1 commit into from
Sep 27, 2024
Merged

refactor: replace glog in flags.go #6530

merged 1 commit into from
Sep 27, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Sep 27, 2024

Proposed changes

  • remove google/glog from flags.go
  • move log levels to their own package

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner September 27, 2024 13:36
@github-actions github-actions bot added the go Pull requests that update Go code label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 78 lines in your changes missing coverage. Please review.

Project coverage is 53.27%. Comparing base (3d3284f) to head (ba0dab6).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
cmd/nginx-ingress/flags.go 0.00% 77 Missing ⚠️
cmd/nginx-ingress/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6530      +/-   ##
==========================================
- Coverage   53.30%   53.27%   -0.04%     
==========================================
  Files          87       87              
  Lines       16074    16136      +62     
==========================================
+ Hits         8569     8596      +27     
- Misses       7097     7132      +35     
  Partials      408      408              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexFenlon AlexFenlon mentioned this pull request Sep 27, 2024
16 tasks
@pdabelf5 pdabelf5 self-assigned this Sep 27, 2024
@pdabelf5 pdabelf5 merged commit 919ba2d into main Sep 27, 2024
81 checks passed
@pdabelf5 pdabelf5 deleted the flags-glog-refactor branch September 27, 2024 14:27
@AlexFenlon AlexFenlon added the skip changelog Pull requests that don't need to be added to the changelog label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code skip changelog Pull requests that don't need to be added to the changelog
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants