-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace glog in k8s package 2 #6576
Merged
Merged
+109
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6576 +/- ##
==========================================
+ Coverage 53.08% 53.13% +0.05%
==========================================
Files 87 87
Lines 16200 16220 +20
==========================================
+ Hits 8599 8619 +20
+ Misses 7194 7191 -3
- Partials 407 410 +3 ☔ View full report in Codecov by Sentry. |
jjngx
approved these changes
Oct 2, 2024
pdabelf5
added
the
skip changelog
Pull requests that don't need to be added to the changelog
label
Oct 2, 2024
AlexFenlon
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
go
Pull requests that update Go code
skip changelog
Pull requests that don't need to be added to the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Replace
glog
withslog
in k8s package for:NOTE:
Checklist
Before creating a PR, run through this checklist and mark each as complete.