-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use DescribeInstance to retrieve filtered AWS instances #29
Use DescribeInstance to retrieve filtered AWS instances #29
Conversation
2e4ed2d
to
055ef27
Compare
90e01a4
to
79c824f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trjstewart thanks for the PR!
Please see a few suggestions.
We will do some additional testing and let you know if we find any problems.
initial implementation for issue nginxinc#28
79c824f
to
52959aa
Compare
Thanks for the suggestions @pleshakov. I've fixed those few things up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. 🚀
We just need to run some tests and this will be ready.
PS: @pleshakov we need to make a release too, we should wait til this is merged right?
Thanks!
@trjstewart thanks! the changes look good. we'll finish the testing shortly and merge it. @Rulox yep, we'll include this feature into a new release. For the new release, we're also planning to include support for upstream servers parameter (max_fails, max_conns, fail_timeout, slow_start), which we're currently working on. |
@pleshakov do you have an ETA on getting the new release out? Just trying to decide if I want to build the binary myself and put it on our CDN or wait. |
@trjstewart the ETA is 2 weeks. |
@pleshakov I'd be happy to take a look at adding the server parm support if you think that would speed things up and make less work for you guys? |
@trjstewart thanks for your help! We really appreciate it. I am not sure if the release date can be earlier regarding the time the new features are available (we have the team working on these features already). @pleshakov maybe you have more insights on this? In the meantime, this PR is good to go, so merging it now! |
@trjstewart as Raul mentioned, we're already working on the feature. thanks for your help. |
@trjstewart If you are still interested in this, this feature (upstream parameters) has been rolled out on the 0.4-1 version, sorry for the delay. |
Proposed changes
This is an initial implementation to satisfy the minimum requirements of issue #28. It would also close out #6.
Checklist
Before creating a PR, run through this checklist and mark each as complete.