Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Chart: Add support for tolerations #1192

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Helm Chart: Add support for tolerations #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f837f67
Helm Chart: Add support for tolerations
oWretch Oct 24, 2023
82fe190
Update based on feedback in other PR
oWretch Oct 26, 2023
bbc4cb0
Fix README spacing
oWretch Oct 29, 2023
8536bd0
Fix issue with tolerations not deploying
oWretch Oct 29, 2023
2468d83
Merge branch 'main' into f/helm-tolerations
kate-osborn Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deploy/helm-chart/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ The following tables lists the configurable parameters of the NGINX Gateway Fabr
| `nginx.image.pullPolicy` | The `imagePullPolicy` for the NGINX image. | Always |
| `nginx.lifecycle` | The `lifecycle` of the nginx container. | {} |
| `terminationGracePeriodSeconds` | The termination grace period of the NGINX Gateway Fabric pod. | 30 |
| `tolerations` | The `tolerations` of the NGINX Gateway Fabric pod. | [] |
| `affinity` | The `affinity` of the NGINX Gateway Fabric pod. | {} |
| `serviceAccount.annotations` | The `annotations` for the ServiceAccount used by the NGINX Gateway Fabric deployment. | {} |
| `serviceAccount.name` | Name of the ServiceAccount used by the NGINX Gateway Fabric deployment. | Autogenerated |
Expand Down
4 changes: 4 additions & 0 deletions deploy/helm-chart/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ spec:
securityContext:
fsGroup: 1001
runAsNonRoot: true
{{- if .Values.tolerations }}
tolerations:
{{- toYaml .Values.tolerations | nindent 6 }}
{{- end }}
volumes:
- name: nginx-conf
emptyDir: {}
Expand Down
3 changes: 3 additions & 0 deletions deploy/helm-chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ nginx:
## The termination grace period of the NGINX Gateway Fabric pod.
terminationGracePeriodSeconds: 30

## Tolerations for the NGINX Gateway Fabric pod.
tolerations: []

## The affinity of the NGINX Gateway Fabric pod.
affinity: {}

Expand Down
Loading