Remove usage info from log output #1242
Merged
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage info from log output.
Problem: When a critical error occurs at startup, usage information for the binary is dumped into the log output.
Solution: Set
SilenceUsage
andSilenceErrors
to true in the rootcobra.Command
. This problem was discussed here in an older discussion on cobra's github page.Testing: Manually tested these cases (usage is there before the change and is no longer there after the change):
docker restart kind-control-plane
which displayed the error recorded in a non-functional test here.Please focus on (optional): Should I set SilenceUsage in
createProvisionerModeCommand
? Currently its just in the StaticModeCommand. Also, as described in the discussion linked above, it mentions possibly settingSilenceUsage
in the root command, should I instead put that increateRootCommand
?Closes #1105
Checklist
Before creating a PR, run through this checklist and mark each as complete.