Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gateway API to v1.0.0 #1250

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Conversation

kate-osborn
Copy link
Contributor

@kate-osborn kate-osborn commented Nov 15, 2023

Proposed changes

Problems:

  • NGF does not support v1.0.0 of Gateway API.
  • NGF does not use the official PartiallyInvalid condition from Gateway API SDK.
  • Webhook should only be installed when Kubernetes version is <1.25

Solutions:

  • Update to v1.0.0 of Gateway API
  • Replace custom PartiallyInvalid condition with the Gateway API condition
  • Add logic to pipeline and conformance scripts to conditionally install webhook.

Testing:

  • Ran conformance tests. One expected failure
  • Ran through examples
  • Verified install and uninstall instructions

Closes #1183 #1168 #1230

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart labels Nov 15, 2023
@kate-osborn kate-osborn marked this pull request as ready for review November 15, 2023 22:21
@kate-osborn kate-osborn requested a review from a team as a code owner November 15, 2023 22:21
docs/installation.md Outdated Show resolved Hide resolved
@sjberman
Copy link
Contributor

@ADubhlaoich For your awareness, this PR changes some docs that will have to be synced with #1226 once merged.

@pleshakov
Copy link
Contributor

Do we need to specifically disable failed conformance test?

@kate-osborn
Copy link
Contributor Author

Do we need to specifically disable failed conformance test?

I would assume so, but merging is blocked for other reasons right now, so I can't tell.

deploy/helm-chart/README.md Outdated Show resolved Hide resolved
deploy/helm-chart/README.md Outdated Show resolved Hide resolved
deploy/helm-chart/README.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

README.md Outdated Show resolved Hide resolved
@kate-osborn kate-osborn merged commit d939535 into nginxinc:main Nov 16, 2023
21 of 23 checks passed
@sjberman
Copy link
Contributor

@travisamartin For your awareness, this PR changes some docs that will have to be synced with #1226.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Ensure oldest supported Kubernetes version is using webhooks for nightly conformance tests
5 participants