Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NginxProxy CRD and global tracing settings #1870

Merged
merged 15 commits into from
Apr 29, 2024
Merged

Commits on Apr 29, 2024

  1. Support NginxProxy CRD and global tracing settings

    Problem: As a user of NGF
    I want to set the collection point for my traces for my installation of NGF
    So that I can ensure all my traces are sent to the same collection platform.
    
    Solution: Implement the NginxProxy CRD which contains the fields required to configure the collection point for tracing. This resource is attached to the GatewayClass. If the resource is not found, a condition will be set on the GatewayClass to indicate this. The GatewayClass will continue to be Accepted even if the parametersRef is invalid.
    
    This configuration sets the `http` context-level otel directives. The otel module is loaded conditionally based on the existence of this configuration.
    
    Note: tracing is not enabled by this configuration, this only sets high level options. #1828 is required to actually enable tracing on a per-route basis.
    sjberman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    68811f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0e24b7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9c9f72a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ca72108 View commit details
    Browse the repository at this point in the history
  5. Revert arch removal

    sjberman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b994dc2 View commit details
    Browse the repository at this point in the history
  6. Fix nil check

    sjberman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    219bccf View commit details
    Browse the repository at this point in the history
  7. Code review

    sjberman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e7d953c View commit details
    Browse the repository at this point in the history
  8. Remove validator

    sjberman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    585375f View commit details
    Browse the repository at this point in the history
  9. Revert reference check

    sjberman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1fbe4a6 View commit details
    Browse the repository at this point in the history
  10. More specific validators

    sjberman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7453b0b View commit details
    Browse the repository at this point in the history
  11. Rebase and add test

    sjberman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5ef075d View commit details
    Browse the repository at this point in the history
  12. Fix validation calls

    sjberman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    43e79d8 View commit details
    Browse the repository at this point in the history
  13. Fix failing unit test

    sjberman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8081878 View commit details
    Browse the repository at this point in the history
  14. Fix test after rebase

    sjberman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    879fa7b View commit details
    Browse the repository at this point in the history
  15. Code review

    sjberman committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    30df54e View commit details
    Browse the repository at this point in the history