Support response header filter for GRPCRoute #1983
Merged
+41
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: As a user, I want to be able to add ResponseHeaderModifier filter for my GRPCRoutes.
Solution: Add support for ResponseHeaderModifier filter for my GRPCRoutes. The implementation reuses validation and logic from the HTTPRoute implementation. This PR also removes some redundant empty structs in the servers_test.go
Testing: The functionality is identical to HTTPRoute so not much additional testing is required. I tested locally using echo server and grpcurl. I didn't modify the application to configure headers on the upstream side, but we can see the response headers set in the GRPCRoute spec have been returned:
Closes #1935
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.