Avoid cloning the repo/downloading dependencies #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The VM clones the repo every time it's created and downloads the go dependencies. This is time consuming. Solution: Clone the repo in the base image and run `go mod download` so that most of the dependencies are already present. When the VM starts and the repo is nginxinc it will just do a git fetch on the repo to sync it.
lucacome
force-pushed
the
chore/clone-repo
branch
from
0877e16
to
0f84ca0
Compare
sjberman
approved these changes
Jul 24, 2024
kate-osborn
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The VM clones the repo every time it's created and downloads the go dependencies. This is time consuming.
Solution: Clone the repo in the base image and run
go mod downloadso that most of the dependencies are already present. When the VM starts and the repo is nginxinc it will just do a git fetch on the repo to sync it.Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.