-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helm Chart examples #2292
Merged
Merged
Add Helm Chart examples #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
chore
Pull requests for routine tasks
helm-chart
Relates to helm chart
labels
Jul 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2292 +/- ##
=======================================
Coverage 87.74% 87.74%
=======================================
Files 96 96
Lines 6813 6813
Branches 50 50
=======================================
Hits 5978 5978
Misses 778 778
Partials 57 57 ☔ View full report in Codecov by Sentry. |
lucacome
force-pushed
the
chore/examples
branch
3 times, most recently
from
July 31, 2024 00:51
2f3cbf3
to
86cefe2
Compare
sjberman
reviewed
Jul 31, 2024
sjberman
reviewed
Jul 31, 2024
lucacome
force-pushed
the
chore/examples
branch
2 times, most recently
from
July 31, 2024 20:26
1e0c00e
to
a249a6b
Compare
kate-osborn
requested changes
Jul 31, 2024
kate-osborn
requested changes
Aug 1, 2024
ADubhlaoich
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation changes LGTM.
lucacome
force-pushed
the
chore/examples
branch
from
August 1, 2024 18:43
3432454
to
dfc71af
Compare
lucacome
force-pushed
the
chore/examples
branch
from
August 1, 2024 21:42
cebf8e1
to
d9a130c
Compare
kate-osborn
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Pull requests for routine tasks
documentation
Improvements or additions to documentation
helm-chart
Relates to helm chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We don't have an easy way to deploy NGF for common use cases
Solution: Create an examples directory with common use cases for deploying Helm. As an added bonus we can generate manifests automatically from the examples.
Closes #1834
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.