Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing variables and format scripts #2330

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Aug 2, 2024

Proposed changes

Problem: The new variable used in NFR tests was missing from the workflow.

Solution: Add missing variables. Also adds shfmt to format the scripts.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner August 2, 2024 19:33
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 2, 2024
@lucacome
Copy link
Member Author

lucacome commented Aug 2, 2024

pre-commit.ci run

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.74%. Comparing base (156f9d8) to head (70de4f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2330   +/-   ##
=======================================
  Coverage   87.74%   87.74%           
=======================================
  Files          96       96           
  Lines        6830     6830           
  Branches       50       50           
=======================================
  Hits         5993     5993           
  Misses        780      780           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome
Copy link
Member Author

lucacome commented Aug 2, 2024

pre-commit.ci autofix

@lucacome lucacome requested a review from a team August 2, 2024 22:53
@lucacome lucacome merged commit f24ab6f into nginxinc:main Aug 5, 2024
37 checks passed
@lucacome lucacome deleted the chore/scripts branch August 5, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants