Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print logs and events on test failure #2347

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Print logs and events on test failure #2347

merged 4 commits into from
Aug 8, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Aug 8, 2024

Proposed changes

Problem: When the tests fail we don't have any outputs from the containers or the k8s events.

Solution: Print logs and outputs on failure.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: When the tests fail we don't have any outputs from the
containers or the k8s events.

Solution: Print logs and outputs on failure.
@lucacome lucacome requested a review from a team as a code owner August 8, 2024 02:41
@github-actions github-actions bot added the tests Pull requests that update tests label Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (6e26763) to head (c2a8322).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2347   +/-   ##
=======================================
  Coverage   88.07%   88.07%           
=======================================
  Files          97       97           
  Lines        6996     6996           
  Branches       50       50           
=======================================
  Hits         6162     6162           
  Misses        777      777           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/framework/info.go Outdated Show resolved Hide resolved
tests/framework/info.go Outdated Show resolved Hide resolved
tests/framework/info.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lucacome lucacome enabled auto-merge (squash) August 8, 2024 16:27
@lucacome lucacome merged commit 695354f into main Aug 8, 2024
37 checks passed
@lucacome lucacome deleted the tests/add-output branch August 8, 2024 16:40
@lucacome lucacome self-assigned this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants