Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in internal/framework in parallel (1) #2362

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Aug 9, 2024

Proposed changes

More tests in parallel

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner August 9, 2024 20:46
@github-actions github-actions bot added the tests Pull requests that update tests label Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (0ced21f) to head (c0a15d0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2362      +/-   ##
==========================================
- Coverage   95.19%   88.85%   -6.34%     
==========================================
  Files           1      100      +99     
  Lines         229     7513    +7284     
  Branches       50       50              
==========================================
+ Hits          218     6676    +6458     
- Misses         11      781     +770     
- Partials        0       56      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome enabled auto-merge (squash) August 12, 2024 16:19
@lucacome lucacome merged commit 21e0bad into nginxinc:main Aug 12, 2024
37 checks passed
@lucacome lucacome deleted the tests/framework-parallel branch August 12, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants