-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add high level doc for data plane config #2378
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2378 +/- ##
==========================================
- Coverage 88.86% 88.83% -0.03%
==========================================
Files 100 100
Lines 7515 7515
Branches 50 50
==========================================
- Hits 6678 6676 -2
- Misses 781 782 +1
- Partials 56 57 +1 ☔ View full report in Codecov by Sentry. |
f03eee5
to
bf92d4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A few suggestions, but norhing breaking.
bf92d4a
to
4978109
Compare
Problem: As a user, I want to know how I can configure global settings for nginx. Solution: Add a doc that talks about how global data plane config can be set.
4978109
to
762239d
Compare
Problem: As a user, I want to know how I can configure global settings for nginx.
Solution: Add a doc that talks about how global data plane config can be set.
Closes #2246
Closes #2119
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.