Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary telemetry header #2403

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

salonichf5
Copy link
Contributor

@salonichf5 salonichf5 commented Aug 14, 2024

Proposed changes

Problem: There is unnecessary header in telemetry exporter.

Solution: Remove the unnecessary header.

Testing: Verified production telemetry works as expected.

Not posting results due to security reasons.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #2151

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@salonichf5 salonichf5 requested a review from a team as a code owner August 14, 2024 18:37
@github-actions github-actions bot added the tech-debt Short-term pain, long-term benefit label Aug 14, 2024
@salonichf5 salonichf5 changed the title remove unnecessary telemetry header Remove unnecessary telemetry header Aug 14, 2024
@salonichf5 salonichf5 enabled auto-merge (squash) August 14, 2024 23:01
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (34654d7) to head (5451e8c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
+ Coverage   88.86%   88.89%   +0.03%     
==========================================
  Files         100      100              
  Lines        7515     7512       -3     
  Branches       50       50              
==========================================
  Hits         6678     6678              
+ Misses        781      778       -3     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salonichf5 salonichf5 merged commit 3c029b1 into nginxinc:main Aug 15, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Short-term pain, long-term benefit
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove unnecessary header from telemetry exporter configuration
4 participants