Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit increases the default
server_names_hash_bucket_size
to 256 andserver_names_hash_max_size
to 1024 to support hostnames longer than 47 characters.Tested locally using the hostname
abcdefghijklmn.too.long.server.name.example.org
. Verified before the change, we get the errorcould not build server_names_hash, you should increase server_names_hash_bucket_size: 64
, and after the change, there are no errors using this hostname.Closes #632
Checklist
Before creating a PR, run through this checklist and mark each as complete.