Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Prefix matching requires trailing slash #817

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Ensure Prefix matching requires trailing slash #817

merged 2 commits into from
Jul 11, 2023

Commits on Jul 11, 2023

  1. Ensure Prefix matching requires trailing slash 

    Problem: When using a prefix path match, a path such as /foobar would match for the prefix /foo, which should not happen. Prefixes need a "/" delimiter between path segments.

Solution: In order to allow just the prefix without a trailing slash, as well as more path segments using a slash delimiter, we now create two location blocks. One uses exact matching for the configured prefix path, and the other uses prefix matching with a trailing slash.
    @sjberman
    sjberman committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    e9f9058 View commit details
    Browse the repository at this point in the history

  2. Simplify code

    @sjberman
    sjberman committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    e7a3213 View commit details
    Browse the repository at this point in the history