Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add withAccents option to randUserName() #356

Merged
merged 2 commits into from
Jun 30, 2023
Merged

add withAccents option to randUserName() #356

merged 2 commits into from
Jun 30, 2023

Conversation

andersonjoseph
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

randUserName() generates random user names including those with accented characters (e.g: Jiángüo.Karlsdóttir36)

What is the new behavior?

with the option: withAccents: boolean we can control if the function should generate user names with accents or not

randUserName({withAccents: false}) // Rattana.Harrison78
randUserName({withAccents: true}) // Dilóp.Háràldsdóttir93

Does this PR introduce a breaking change?

  • Yes
  • No

@NetanelBasal NetanelBasal merged commit 046f1de into ngneat:main Jun 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants