Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to allow randCountryCode to generate alpha3 syntax codes #376

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

MathRobin
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

randCountryCode() // US

Currently, randCountryCode only generates alpha2 country codes. With this PR, the users can asks for alpha3 syntax with an optionnal additional option.

What is the new behavior?

randCountryCode({ alpha3 : true }) // KRW

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Country codes can be 2 or 3 chars long. This commit add alpha3 optionnal
param to switch from default alpha2 to alpha3 syntax.
Country codes can be 2 or 3 chars long. This commit add alpha3 optionnal
param to switch from default alpha2 to alpha3 syntax.
Copy link

stackblitz bot commented Feb 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal
Copy link
Member

Can you check the build action, please?

@NetanelBasal NetanelBasal merged commit 6ffa858 into ngneat:main Feb 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants