fix: 🐛 move data open to a better hool

ngneat · Jan 5, 2023 · 6e68832 · 6e68832
1 parent 44e45f2
commit 6e68832
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/projects/ngneat/helipopper/src/lib/tippy.directive.ts b/projects/ngneat/helipopper/src/lib/tippy.directive.ts
@@ -233,8 +233,10 @@ export class TippyDirective implements OnChanges, AfterViewInit, OnDestroy, OnIn
             instance.show();
           }
         },
-        onShow: instance => {
+        onShown() {
           this.host.setAttribute('data-tippy-open', '');
+        },
+        onShow: instance => {
           this.zone.run(() => {
             const content = this.resolveContent();
             if (isString(content)) {
@@ -253,8 +255,10 @@ export class TippyDirective implements OnChanges, AfterViewInit, OnDestroy, OnIn
           }
           this.globalConfig.onShow?.(instance);
         },
-        onHidden: instance => {
+        onHide() {
           this.host.removeAttribute('data-tippy-open');
+        },
+        onHidden: instance => {
           this.destroyView();
           this.zone.run(() => {
             this.isVisible = false;