feat: removed config 'disableOnNilValue' in favour of default behaviour

ngneat · May 18, 2021 · 8bfd4b6 · 8bfd4b6
1 parent 8c14a5e
commit 8bfd4b6
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -250,7 +250,6 @@ visible = new EventEmitter<boolean>();
 ### Global Config
 - You can pass any `tippy` option at global config level. 
 - `beforeRender` - Hook that'll be called before rendering the tooltip content ( applies only for string )
-- `disableOnNilValue` - Boolean flag that disables the tooltip if the assigned value is null or undefined. This can be seen as a shortcut to `isEnable`
 
 ### Create `tippy` Programmatically
 

diff --git a/projects/ngneat/helipopper/src/lib/tippy.directive.ts b/projects/ngneat/helipopper/src/lib/tippy.directive.ts
@@ -186,7 +186,7 @@ export class TippyDirective implements OnChanges, AfterViewInit, OnDestroy, OnIn
   }
 
   private createInstanceOnNonNilValue() {
-    if (this.globalConfig.disableOnNilValue && this.content !== null && this.content !== undefined) {
+    if (this.content !== null && this.content !== undefined) {
       this.createInstance();
     }
   }
@@ -208,10 +208,7 @@ export class TippyDirective implements OnChanges, AfterViewInit, OnDestroy, OnIn
         this.globalConfig.onCreate?.(instance);
       },
       onShow: instance => {
-        this.zone.run(() => {
-          this.instance.setContent(this.resolveContent());
-        });
-
+        this.zone.run(() => this.instance.setContent(this.resolveContent()));
         if (this.useHostWidth) {
           instance.popper.style.width = this.hostWidth;
           instance.popper.style.maxWidth = this.hostWidth;
@@ -234,7 +231,7 @@ export class TippyDirective implements OnChanges, AfterViewInit, OnDestroy, OnIn
   }
 
   private resolveContent() {
-    if (this.globalConfig.disableOnNilValue && (this.content === null || this.content === undefined)) {
+    if (this.content === null || this.content === undefined) {
       return null;
     }
 

diff --git a/projects/ngneat/helipopper/src/lib/tippy.types.ts b/projects/ngneat/helipopper/src/lib/tippy.types.ts
@@ -36,7 +36,6 @@ export interface TippyConfig extends TippyProps {
   variations: Record<string, Partial<TippyProps>>;
   defaultVariation: keyof TippyConfig["variations"];
   beforeRender?: (text: string) => string;
-  disableOnNilValue?: boolean;
 }
 
 export function coerceElement(element: TippyElement) {

diff --git a/src/app/app.module.ts b/src/app/app.module.ts
@@ -29,8 +29,7 @@ import { popperVariation, TippyModule, tooltipVariation, withContextMenuVariatio
           ...popperVariation,
           theme: "light-border"
         }
-      },
-      disableOnNilValue: true
+      }
     })
   ],
   providers: [],