Implement lazy retrieval of series from object store. (thanos-io#5837)

* Implement lazy retrieval of series from object store.

The bucket store fetches series in a single blocking operation from
object storage. This is likely not an ideal strategy when it comes to
latency and resource usage. In addition, it causes the store to buffer
everything in memory before starting to send results to queriers.

This commit modifies the series retrieval to use the proxy response heap
and take advantage of the k-way merge used in the proxy store.

Signed-off-by: Filip Petkovski <[email protected]>

* Add batching

Signed-off-by: Filip Petkovski <[email protected]>

* Preload series in batches

Signed-off-by: Filip Petkovski <[email protected]>

* Emit proper stats

Signed-off-by: Filip Petkovski <[email protected]>

* Extract block series client

Signed-off-by: Filip Petkovski <[email protected]>

* Fix CI

Signed-off-by: Filip Petkovski <[email protected]>

* Address review comments

Signed-off-by: Filip Petkovski <[email protected]>

* Use emptyPostingsCount in lazyRespSet

Signed-off-by: Filip Petkovski <[email protected]>

* Reuse chunk metas

Signed-off-by: Filip Petkovski <[email protected]>

* Avoid overallocating for small responses

Signed-off-by: Filip Petkovski <[email protected]>

* Add metric for chunk fetch time

Signed-off-by: Filip Petkovski <[email protected]>

* Regroup imports

Signed-off-by: Filip Petkovski <[email protected]>

* Change counter to uint64

Signed-off-by: Filip Petkovski <[email protected]>

Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: fpetkovski <[email protected]>

.gitignore

@@ -17,6 +17,9 @@ kube/.minikube
 data/
 test/e2e/e2e_*
 
+# Ignore benchmarks dir.
+benchmarks/
+
 # Ignore promu artifacts.
 /.build
 /.release

cmd/thanos/query.go

@@ -29,6 +29,7 @@ import (
 
 	v1 "github.com/prometheus/prometheus/web/api/v1"
 	"github.com/thanos-community/promql-engine/engine"
+
 	apiv1 "github.com/thanos-io/thanos/pkg/api/query"
 	"github.com/thanos-io/thanos/pkg/compact/downsample"
 	"github.com/thanos-io/thanos/pkg/component"
@@ -97,6 +98,7 @@ func registerQuery(app *extkingpin.App) {
 
 	queryTimeout := extkingpin.ModelDuration(cmd.Flag("query.timeout", "Maximum time to process query by query node.").
 		Default("2m"))
+
 	promqlEngine := cmd.Flag("query.promql-engine", "PromQL engine to use.").Default(string(promqlEnginePrometheus)).
 		Enum(string(promqlEnginePrometheus), string(promqlEngineThanos))
 

cmd/thanos/store.go

@@ -6,6 +6,7 @@ package main
 import (
 	"context"
 	"fmt"
+	"strconv"
 	"time"
 
 	"github.com/alecthomas/units"
@@ -56,6 +57,7 @@ type storeConfig struct {
 	httpConfig                  httpConfig
 	indexCacheSizeBytes         units.Base2Bytes
 	chunkPoolSize               units.Base2Bytes
+	seriesBatchSize             int
 	maxSampleCount              uint64
 	maxTouchedSeriesCount       uint64
 	maxDownloadedBytes          units.Base2Bytes
@@ -129,6 +131,9 @@ func (sc *storeConfig) registerFlag(cmd extkingpin.FlagClause) {
 	cmd.Flag("block-meta-fetch-concurrency", "Number of goroutines to use when fetching block metadata from object storage.").
 		Default("32").IntVar(&sc.blockMetaFetchConcurrency)
 
+	cmd.Flag("debug.series-batch-size", "The batch size when fetching series from TSDB blocks. Setting the number too high can lead to slower retrieval, while setting it too low can lead to throttling caused by too many calls made to object storage.").
+		Hidden().Default(strconv.Itoa(store.SeriesBatchSize)).IntVar(&sc.seriesBatchSize)
+
 	sc.filterConf = &store.FilterConfig{}
 
 	cmd.Flag("min-time", "Start of time range limit to serve. Thanos Store will serve only metrics, which happened later than this value. Option can be a constant time in RFC3339 format or time duration relative to current time, such as -1d or 2h45m. Valid duration units are ms, s, m, h, d, w, y.").
@@ -340,6 +345,7 @@ func runStore(
 		store.WithChunkPool(chunkPool),
 		store.WithFilterConfig(conf.filterConf),
 		store.WithChunkHashCalculation(true),
+		store.WithSeriesBatchSize(conf.seriesBatchSize),
 	}
 
 	if conf.debugLogging {