Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: add cypress testing for example app #1556

Closed
brandonroberts opened this issue Feb 15, 2019 · 3 comments · Fixed by #1565
Closed

Example: add cypress testing for example app #1556

brandonroberts opened this issue Feb 15, 2019 · 3 comments · Fixed by #1565
Assignees
@timdeschryver
Labels
Project: Example App

Comments

@brandonroberts
Copy link
Member

We've already talked about this, but had no official issue to track.
@timdeschryver
Copy link
Member

Current status: Cypress tests are available at /wip/example-cypress but the bazel build is failing because the build files aren't formatted - https://circleci.com/gh/ngrx/platform/5064.

@brandonroberts
Copy link
Member Author

I'll take another look over the weekend

@brandonroberts
Copy link
Member Author

You should be unblocked now. I rebased the branch on master, added a fix, and force pushed the changes.

@timdeschryver timdeschryver mentioned this issue Feb 18, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timdeschryver timdeschryver

Labels
Project: Example App
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(Example): add cypress tests ngrx/platform
2 participants
@brandonroberts @timdeschryver