Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(eslint-plugin): add docs for signal-store-feature-should-use-generic-type #4521

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

timdeschryver
Copy link
Member

…eric-type

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #4502

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR continues the work from #4515, which was disbanded.

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 8e8e549
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/66e08616ba4f1e0008dd50e2
😎 Deploy Preview https://deploy-preview-4521--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -18,25 +18,21 @@ This rule ensures that state changes are only managed by the Signal Store to pre
Examples of **incorrect** code for this rule:

```ts
// SUGGESTION ❗
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the referenced PR, this is removed to keep things consistent across the different rules.

@brandonroberts brandonroberts merged commit 51df3ae into main Sep 16, 2024
11 checks passed
@brandonroberts brandonroberts deleted the issue/4502 branch September 16, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for the ESLint rule signal-store-feature-should-use-generic-type
3 participants