Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signals): remove usage of SIGNAL from @angular/core/primitives/signals package #4530

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Sep 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  • The SIGNAL symbol is imported from the @angular/core/primitives/signals package. This is a private import from Angular. This causes issues syncing the NgRx Signals library into G3.
  • Removes readonly from internal signal as this is checked at the type level

Closes #

What is the new behavior?

The SIGNAL symbol is no longer imported from the @angular/core/primitives/signals package.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit a26bbb3
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/66f1bfbf873fb000085e8459

modules/signals/src/state-source.ts Outdated Show resolved Hide resolved
modules/signals/src/state-source.ts Outdated Show resolved Hide resolved
modules/signals/src/state-source.ts Outdated Show resolved Hide resolved
modules/signals/src/state-source.ts Outdated Show resolved Hide resolved
@brandonroberts brandonroberts merged commit cae429a into main Sep 24, 2024
11 checks passed
@brandonroberts brandonroberts deleted the fix-remove-signal-primitives branch September 24, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants