Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngtcp2_crypto: add support for additional handshake err codes #157

Closed

Conversation

jasnell
Copy link
Contributor

@jasnell jasnell commented Oct 9, 2019

When SSL_dl_handshake() returns either an SSL_ERROR_WANT_CLIENT_HELLO_CB
or SSL_ERROR_WANT_X509_LOOKUP, return specific error codes rather than
-1 so that those conditions can be differentiated and handled
appropriately

When SSL_dl_handshake() returns either an SSL_ERROR_WANT_CLIENT_HELLO_CB
or SSL_ERROR_WANT_X509_LOOKUP, return specific error codes rather than
-1 so that those conditions can be differentiated and handled
appropriately
@tatsuhiro-t
Copy link
Member

Thank you for PR.
I understand that differentiating those error code is important for OpenSSL users and ngtcp2 crypto lib should notify this to the caller. I'm thinking about the best way to incorporate this in a vendor neutral way. It might be nice to provide a place to store the implementation dependent error code and its header file to describe its own error code.

@tatsuhiro-t
Copy link
Member

Hmm, it might be sufficient to define common error code and implementation dependent error code space. The current use of ngtcp2 crypto lib requires application to know the underlying crypto library after all.

@tatsuhiro-t
Copy link
Member

Cherry-picked as 206eefb with some arrangements of error code in a separate file (see 0232fb0)

@jasnell
Copy link
Contributor Author

jasnell commented Oct 14, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants