Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): upgrade dependencies for Angular v8+ #1094

Merged
merged 1 commit into from
Feb 5, 2020
Merged

feat(core): upgrade dependencies for Angular v8+ #1094

merged 1 commit into from
Feb 5, 2020

Conversation

peterblazejewicz
Copy link
Contributor

We are using this lib on production and we migrated most of the content to version 8:

  • dependencies upgrade
  • minor changes after version upgrade
  • minor configuration changes

Thanks!

arunredhu
arunredhu previously approved these changes Jul 26, 2019
Strapazzon
Strapazzon previously approved these changes Sep 4, 2019
@f-masche
Copy link

Is this pull request still active, and is there a possibility that this is merged anytime soon?
This is a big deal for many projects relying on ng update using angular 8.
Thanks you!

@juristr
Copy link
Contributor

juristr commented Nov 23, 2019

This is a big deal for many projects relying on ng update using angular 8.

Also Angular 9 being just about to land 😉. Tbh we upgraded our app to ng 8 a while back and we're using ngx translate. Didn't see any issues.

BREAKING CHANGE: Angular v8+ is now required
@ocombe ocombe dismissed stale reviews from Strapazzon and arunredhu via f6a923f February 5, 2020 17:08
@ocombe ocombe changed the title feat(Angular 8): dependencies upgraded feat(core): upgrade dependencies for Angular v8+ Feb 5, 2020
@ocombe ocombe merged commit 9a721f5 into ngx-translate:master Feb 5, 2020
@peterblazejewicz peterblazejewicz deleted the feat/upgrade-ng-8 branch February 5, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants