fix(directive): trim white spaces to find matching keys #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steg0139
previously approved these changes
Dec 9, 2019
|
Nice work, looks like this has been an issue since version 10.0.0... LGTM |
|
When is this getting merged and released? |
ocombe
previously approved these changes
Feb 5, 2020
ocombe
force-pushed
the
issue-998-recursive-translation
branch
from
03d2fcd
to
904af26
Compare
ocombe
approved these changes
Feb 5, 2020
ocombe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #998: Translate directive whitespace handling can cause erroneous recursive translation