Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated type of TranslatePipe to properly represent already handled types #1217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated type of TranslatePipe to properly represent already handled types #1217

wants to merge 1 commit into from

Conversation

PhilippMeissner
Copy link

@PhilippMeissner PhilippMeissner commented Jun 3, 2020 •
edited
Loading

This PR fixes #794 and fixes #1214.

@PhilippMeissner
Copy link
Author

@ocombe Maybe you can have a quick glance at this? It would really help us out to have this merged and released 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiBirkenstock KaiBirkenstock KaiBirkenstock approved these changes

@tiaguinho tiaguinho tiaguinho approved these changes

@cice cice cice approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing types in TranslatePipe Support AoT fullTemplateTypeCheck flag + AsyncPipe
4 participants
@PhilippMeissner @cice @tiaguinho @KaiBirkenstock