fix(TranslateService): compile translations only once #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ocombe Can you please take a look at this? Because of this bug our app is unresponsive for ~5 seconds only compiling the messages over and over again when the initial page the user opens has many keys. |
|
@saithis This is an amazing pull request, thank you! This bug you've fixed ruined my Cordova web app — everything was fast in my browser on localhost but when i built my app and opened it on mobile phone I've been waiting ~15 seconds for my app to start :) |
ocombe
approved these changes
Nov 14, 2018
|
that's a great PR, thanks! |
|
Available in 11.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #955