Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace wrong rows when use setRows API with filter #1932

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • Fixed an issue where using the setRows API when filtering would change the wrong row and create duplicate rows.
    • It was caused by looking for the row index of the row to be changed in unfiltered data and finding the wrong row index.

As-Is

To-Be


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link

@sunyoungBae sunyoungBae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대부분의 변경사항에 동의합니다.
테스트 쪽에 사소한 리뷰 몇개 추가했습니다. 주요 로직에 영향을 끼치진 않으므로 바쁘시면 변경하지 않으셔도 됩니다.

@jajugoguma jajugoguma merged commit 050b4ba into master Jul 3, 2023
3 of 4 checks passed
@jajugoguma jajugoguma deleted the fix/duplicated_rows_when_set_rows_with_filter branch July 3, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants