include 'name' in info hash as that is required field of omniauth
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chema. minor refactor of `extra` hash contents. Also prune out keys with null (or empty) values as most other omniauth providers do and seems to be a good practice. For 'extra' hash, split details into their own hash for 'id_info' and 'user_info' so it's clear where the values come from and common keys do not clobber each other. Add raw 'id_token' to extra as well as it's sometimes useful for troubleshooting and is added by other providers.
nhosoya
approved these changes
Jun 19, 2020
Comment on lines
+117
to
+122
| def prune!(hash) | ||
| hash.delete_if do |_, v| | ||
| prune!(v) if v.is_a?(Hash) | ||
| v.nil? || (v.respond_to?(:empty?) && v.empty?) | ||
| end | ||
| end |
There was a problem hiding this comment.
Thank you for introducing a good practice.
https://github.com/zquestz/omniauth-google-oauth2/blob/b23dc47975d8e8e6a1727a72ab22f096477d7688/lib/omniauth/strategies/google_oauth2.rb#L150-L155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include 'name' in
infohash as that is required field of omniauth schema. minor refactor ofextrahash contents.Also prune out keys with null (or empty) values as most other omniauth providers do and seems to be a good practice. For 'extra' hash, split details into their own hash for 'id_info' and 'user_info' so it's clear where the values come from and common keys do not clobber each other. Add raw 'id_token' to extra as well as it's sometimes useful for troubleshooting and is added by other providers.