Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTO_MIGRATE removed but still in .env.example and documentation #561

Closed
joshmedeski opened this issue Jun 2, 2021 · 4 comments · Fixed by #631
Closed

AUTO_MIGRATE removed but still in .env.example and documentation #561

joshmedeski opened this issue Jun 2, 2021 · 4 comments · Fixed by #631

Comments

@joshmedeski
Copy link
Contributor

I see the AUTO_MIGRATE functionality was removed, see 85c3d14

In the environmental variables, this should be removed. It would even be helpful to include an error message if that variable is set to true to let users know it is no longer supported.

@joshmedeski
Copy link
Contributor Author

I noticed the migrations documentation talks about Hasura handling the migrations. It would be good to mention what the AUTO_MIGRATE feature does on HBP and how to combine it with Hasura's migrations.

@elitan
Copy link
Contributor

elitan commented Jun 4, 2021

Yes. Thanks for spotting this.

For reference: HBP now handles its own migrations (#507) and will handle its own metadata soon (#546).

@amal-chandran
Copy link

amal-chandran commented Jun 17, 2021

@elitan what are the issues with hasura based cli migrations? #546 #507
can we persist "AUTO_MIGRATE" env so that we can override the default behavior we can set "AUTO_MIGRATE" as true by default right ?

@elitan
Copy link
Contributor

elitan commented Jun 17, 2021

AUTO_MIGRATE is not really related to the fact that HBP will handle its own migrations and metadata.

AUTO_MIGRATE was previously used to auto migrate from HBP v1 to HBP v2.

Generally, I don't think we'll allow to opt-out of HBP's own migrations and metadata.

@elitan elitan mentioned this issue Jul 14, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants