Manage migrations with postgres-migrations #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HBP specific migrations (e.g. auth, storage) are managed by HBP itself
nunopato
changed the title
|
This will also close #354. |
Fix missing dependencies to use cli_ext
nunopato
changed the title
nunopato
requested review from
komninoschatzipapas and
elitan
and removed request for
komninoschatzipapas
elitan
reviewed
May 14, 2021
elitan
approved these changes
May 15, 2021
pjindal91
reviewed
May 29, 2021
| try { | ||
| await client.connect() | ||
| await migrate({ client }, './db/migrations') | ||
| } finally { |
There was a problem hiding this comment.
It's by design I think. If the migration fails HBP will fail (and restart) and try to apply the migrations again.
Docker should handle the restart with ex restart: always in docker-compose.
@nunopato Is that correct or are we in fact missing something here?
There was a problem hiding this comment.
yeah, we want the exception to be thrown and the container fail to start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HBP-specific migrations (
auth) are currently being managed by Hasura, which makes it hard to release schema changes toauth. This PR addspostgres-migrationsso that HBP manages its own migrations/schemas../db./db/migrations- migrations here should be specific to theauthschema../db/00_init-schema.sqlcreates extensions and the auth schema (not the tables) and it is used withdocker-entrypoint-initdbwhen creating the DB the first time - this initialization will soon be moved to http://github.com/nhost/postgres.The metadata is still managed by Hasura and lives in
./db/hasura/metadata.